search

pulumi / pulumi-terraform-bridge

A library allowing providers built with the Terraform Plugin SDK to be bridged into Pulumi.
Apache License 2.0
184 stars 42 forks source link

PlanResourceChange: do not call state upgraders during Create #2050

Closed t0yv0 closed 3 weeks ago

t0yv0 commented 4 weeks ago

When testing rolling out PlanResourceChange to the entirety of AWS, basic tests such as TestAccCloudWatch started failing with a panic from the provider upgrade machinery. The issue is that provider upgrades should not be called on Create. This is now fixed.

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 61.37%. Comparing base (1f9028f) to head (fc1cf83). Report is 1 commits behind head on master.

Files Patch % Lines
pkg/tests/cross-tests/tf_driver.go 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2050 +/- ## ========================================== - Coverage 61.39% 61.37% -0.02% ========================================== Files 334 334 Lines 44950 44947 -3 ========================================== - Hits 27595 27585 -10 - Misses 15829 15836 +7 Partials 1526 1526 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

VenelinMartinov commented 3 weeks ago

Verified this fixes the gitlab example in https://github.com/pulumi/pulumi-terraform-bridge/issues/2034