search

pulumi / pulumi-terraform-bridge

A library allowing providers built with the Terraform Plugin SDK to be bridged into Pulumi.
Apache License 2.0
183 stars 41 forks source link

Fix proposed new unknown blocks #2060

Closed VenelinMartinov closed 2 weeks ago

VenelinMartinov commented 3 weeks ago

This updates our objchange algorithm with the newest one from the OpenTofu repo. This fixes an issue with the way unknown sets are presented to TF.

fixes https://github.com/pulumi/pulumi-terraform-bridge/issues/1951

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 15.86207% with 488 lines in your changes missing coverage. Please review.

Project coverage is 61.20%. Comparing base (ba48631) to head (b6947ee).

Files Patch % Lines
...m/sdk-v2/internal/tf/plans/objchange/plan_valid.go 1.21% 324 Missing and 1 partial :warning:
...im/sdk-v2/internal/tf/plans/objchange/objchange.go 40.93% 119 Missing and 8 partials :warning:
...im/sdk-v2/internal/tf/configs/configschema/path.go 0.00% 31 Missing :warning:
...rnal/tf/configs/configschema/nestingmode_string.go 0.00% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2060 +/- ## ========================================== - Coverage 61.57% 61.20% -0.37% ========================================== Files 334 337 +3 Lines 44955 45177 +222 ========================================== - Hits 27681 27651 -30 - Misses 15750 16005 +255 + Partials 1524 1521 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

t0yv0 commented 3 weeks ago

The objchange update is amazing. This can be a very big change now may trip up downstream tests, though probably a good one. Great find!!

VenelinMartinov commented 2 weeks ago

Well, this passes for me locally...

Had to merge master - apparently CI does not run on your branch but on the merged result.