Closed VenelinMartinov closed 1 month ago
I expect plan modifiers to fully work, curious if you find a counter-example.
I think that https://github.com/pulumi/pulumi-aws/issues/4273 is an example of this in pulumi-aws
I think I have a repro: https://github.com/pulumi/pulumi-terraform-bridge/pull/2217
I'm assuming this is connected to https://github.com/pulumi/pulumi-terraform-bridge/issues/2218 and will investigate as part of that.
Not 100% sure about this anymore - tried to repro in pulumi-random:
These properties have plan modifiers and they seem to be working: https://github.com/hashicorp/terraform-provider-random/blame/455294a2038f3cf39a31f8eda231b95f190df250/internal/provider/resource_string.go#L453
The above program outputs False, False, False, False
I can't reproduce the AWS issue anymore either if I use the latest bridge@master so something must have been fixed (I can reproduce on latest aws which is on bridge@v3.87.0)
This turned out to be a red herring - the test was set up wrong - plan modifiers are applied fine as long as the provider is implemented correctly to apply the plan, not the config:
https://github.com/pulumi/pulumi-terraform-bridge/pull/2217 will add a regression test here.
What happened?
Looking at the code around PF Diff it doesn't look like PlanModifiers are used in ProposedNew anywhere - does that mean we ignore these?
Example
This should yield a different plan then when the PlanModifier is missing.
Output of
pulumi about
.
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction. To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).