Open VenelinMartinov opened 1 month ago
That's a good find, probably would be breaking to roll this out but in a good way (emphasize at compile time that programs are doing something wrong). There is a chance from what I remember that TF would panic or otherwise fail at runtime if a user attempts to set these. If this is true, we can fix it without worrying about breaking program compilation because the programs that would be affected are already broken at runtime, just need good changelog discipline.
Yeah, TF does panic at runtime if the user tries to set a fully computed property, so this change should be entirely safe to make.
The tricky bit here is that the types are shared between inputs and outputs currently, which is how we ended up with the Computed properties in the input types.
What happened?
In https://github.com/pulumi/pulumi-gcp/issues/2096 it was discovered that Computed + !Optional + !Required is not respected on nested object properties in tfgen.
The schemas is generated with the property as settable by the user:
Example
.
Output of
pulumi about
.
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction. To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).