search

pulumi / pulumi-terraform-bridge

A library allowing Terraform providers to be bridged into Pulumi.
Apache License 2.0
197 stars 43 forks source link

Set up CI for feature flags #2432

Closed VenelinMartinov closed 1 month ago

VenelinMartinov commented 1 month ago

What happened?

We roll out bridge features under feature flags and these tend to take a while. We'd like to make sure that new development in the repo does not break these, so we should run CI for each feature flag.

Had some issues with this during https://github.com/pulumi/pulumi-terraform-bridge/issues/1785

Example

.

Output of pulumi about

.

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction. To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

VenelinMartinov commented 1 month ago

Specifically we'd like to run CI on https://github.com/pulumi/home/issues/3560

iwahbe commented 1 month ago

We would presumably need to run CI on all permutations of feature flags, since if we run CI with all flags on but our releases don't have all flags on, we would have untested code being released.

VenelinMartinov commented 1 month ago

Yeah, all permutations is the plan, or at least the meaningful ones

pulumi-bot commented 1 month ago

This issue has been addressed in PR #2446 and shipped in release v3.92.0.