search

pulumi / pulumi-terraform-bridge

A library allowing Terraform providers to be bridged into Pulumi.
Apache License 2.0
199 stars 43 forks source link

Pulumi diff does not show details but ignoring userdata fixes the diff #2441

Open t0yv0 opened 1 month ago

t0yv0 commented 1 month ago

What happened?

Coming here from re-triaging https://github.com/pulumi/pulumi-aws/issues/3449#issuecomment-2372369770

Seems from the data and behavior that the diff in question is strictly about the userdata field but the detailed diff is omitted and it's invisible. Would be very nice to make sure detailed diff works as expected here. 

pulumi preview                                 ~/Library/Mobile Documents/com~apple~CloudDocs/pulumi-bugs/pulumi-aws-3449
Previewing update (dev)

View in Browser (Ctrl+O): https://app.pulumi.com/anton-pulumi-corp/pulumi-aws-3449/dev/previews/4f70d47f-cf53-4800-8031-176b4aae19c6

     Type                 Name                 Plan       
     pulumi:pulumi:Stack  pulumi-aws-3449-dev             
 ~   └─ aws:ec2:Instance  web                  update     

Resources:
    ~ 1 to update
    3 unchanged

anton@anton-mbp-m3> pulumi preview --diff                              ~/Library/Mobile Documents/com~apple~CloudDocs/pulumi-bugs/pulumi-aws-3449
Previewing update (dev)

View Live: https://app.pulumi.com/anton-pulumi-corp/pulumi-aws-3449/dev/previews/5b26ba50-0221-430f-bfdc-20a4843c8a1c

  pulumi:pulumi:Stack: (same)
    [urn=urn:pulumi:dev::pulumi-aws-3449::pulumi:pulumi:Stack::pulumi-aws-3449-dev]
    ~ aws:ec2/instance:Instance: (update)
        [id=i-0181da549eaa4ea99]
        [urn=urn:pulumi:dev::pulumi-aws-3449::aws:ec2/instance:Instance::web]
        [provider=urn:pulumi:dev::pulumi-aws-3449::pulumi:providers:aws::default_6_52_0::54635b0e-e8f0-4f65-b618-e1dced5fffa7]
        getPasswordData        : false
        launchTemplate         : {
            id        : "lt-087125f9b57300b59"
            version   : "$Latest"
        }
        sourceDestCheck        : true
        tags                   : {
            Name: "HelloWorld"
        }
        tagsAll                : {
            Name: "HelloWorld"
        }
        userDataReplaceOnChange: false
Resources:              
    ~ 1 to update
    3 unchanged

Example

See linked issue.

Output of pulumi about

See linked issue.

Additional context

N/A

Contributing

Vote on this issue by adding a 👍 reaction. To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

guineveresaenger commented 1 month ago

Linking https://github.com/pulumi/pulumi-terraform-bridge/issues/1895 for reference.

VenelinMartinov commented 1 month ago

Should we add this to the detailed diff epic, to verify once we finish the rewrite?