search

pulumi / pulumi-terraform-bridge

A library allowing Terraform providers to be bridged into Pulumi.
Apache License 2.0
200 stars 43 forks source link

Strip Output and secret types from detailed diff input #2526

Closed VenelinMartinov closed 3 days ago

VenelinMartinov commented 1 month ago

The detailed diff algorithm in the bridge does not need to care about secrets as it can not expose these. We should make sure that these are not passed in.

Currently the bridge uses a flag to the engine to say that both Secrets and Outputs are not supported but this might change with https://github.com/pulumi/pulumi-terraform-bridge/issues/1506

t0yv0 commented 4 weeks ago

Thank you for logging this. I think it is not a problem as of today (AFAIK), but will become one with https://github.com/pulumi/pulumi-terraform-bridge/issues/1506 so that would be something we need to account for if doing that.

VenelinMartinov commented 1 week ago

Turns out this is necessary for PF support, working on a fix in https://github.com/pulumi/pulumi-terraform-bridge/pull/2643