search

pulumi / pulumi-terraform-bridge

A library allowing Terraform providers to be bridged into Pulumi.
Apache License 2.0
199 stars 43 forks source link

Remove non PRC tests #2575

Closed VenelinMartinov closed 2 weeks ago

VenelinMartinov commented 3 weeks ago

We have rolled PRC out everywhere, no need to test non-PRC anymore

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.08%. Comparing base (0603908) to head (51625a0). Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
.../internal/tests/cross-tests/upgrade_state_check.go 25.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2575 +/- ## ========================================== - Coverage 62.83% 61.08% -1.75% ========================================== Files 385 385 Lines 51649 51642 -7 ========================================== - Hits 32455 31548 -907 - Misses 17371 18284 +913 + Partials 1823 1810 -13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

iwahbe commented 2 weeks ago

Also, it doesn't look like we have rolled it out everywhere:

https://github.com/pulumi/pulumi-fastly/blob/6f18accf90b35730fef8285e9c4a239de3bccefb/provider/resources.go#L75-L78

If shimv2.WithPlanResourceChange doesn't do anything anymore, then please add a comment to the option that explains that (like shimv2.WithDiffStrategy):

https://github.com/pulumi/pulumi-terraform-bridge/blob/f0919962932be8de529169e4974e09552c8002b4/pkg/tfshim/sdk-v2/provider_options.go#L62-L68

VenelinMartinov commented 2 weeks ago

Well spotted @iwahbe

PR superseded by https://github.com/pulumi/pulumi-terraform-bridge/pull/2594