Closed iwahbe closed 2 days ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 69.97%. Comparing base (
3561cab
) to head (fc9faea
). Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
I am a bit confused as to why the test passes. Shouldn't it fail according to your comment in https://github.com/pulumi/pulumi-terraform-bridge/issues/2637?
I am a bit confused as to why the test passes. Shouldn't it fail according to your comment in #2637?
I was surprised that they pass too. Investigation showed that .NestedType
is applied later, and applies to the property type, not the name.
Should we also add a test which captures the failure in https://github.com/pulumi/pulumi-terraform-bridge/issues/2637?
Should we also add a test which captures the failure in #2637?
I think the failure there is more communication then technical. I need to touch base with @zbuchheit, but I think the problem there is I was reading properties as property names and @zbuchheit meant property types.
This PR has been shipped in release v3.96.0.
Motivated by https://github.com/pulumi/pulumi-terraform-bridge/issues/2637
Concerningly, it looks like
.NestedType
wasn't under test before.