pulumi / pulumi-terraform-bridge

A library allowing Terraform providers to be bridged into Pulumi.
Apache License 2.0
199 stars 43 forks source link

Add a test for tfbridge.SchemaInfo.NestedType #2641

Closed iwahbe closed 2 days ago

iwahbe commented 2 days ago

Motivated by https://github.com/pulumi/pulumi-terraform-bridge/issues/2637

Concerningly, it looks like .NestedType wasn't under test before.

codecov[bot] commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.97%. Comparing base (3561cab) to head (fc9faea). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2641 +/- ## ========================================== + Coverage 69.95% 69.97% +0.01% ========================================== Files 367 367 Lines 44503 44503 ========================================== + Hits 31132 31140 +8 + Misses 11741 11734 -7 + Partials 1630 1629 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

VenelinMartinov commented 2 days ago

I am a bit confused as to why the test passes. Shouldn't it fail according to your comment in https://github.com/pulumi/pulumi-terraform-bridge/issues/2637?

iwahbe commented 2 days ago

I am a bit confused as to why the test passes. Shouldn't it fail according to your comment in #2637?

I was surprised that they pass too. Investigation showed that .NestedType is applied later, and applies to the property type, not the name.

VenelinMartinov commented 2 days ago

Should we also add a test which captures the failure in https://github.com/pulumi/pulumi-terraform-bridge/issues/2637?

iwahbe commented 2 days ago

Should we also add a test which captures the failure in #2637?

I think the failure there is more communication then technical. I need to touch base with @zbuchheit, but I think the problem there is I was reading properties as property names and @zbuchheit meant property types.

pulumi-bot commented 11 hours ago

This PR has been shipped in release v3.96.0.