search

pulumi / pulumi-terraform

A resource package that allows Pulumi programs to use Terraform state
Apache License 2.0
112 stars 18 forks source link

Upgrade pulumi-terraform to v1.4.6 #729

Closed aq17 closed 1 year ago

aq17 commented 1 year ago

Fixes #726

t0yv0 commented 1 year ago

Do we know what's up with failing tests? Thanks.

aq17 commented 1 year ago

Do we know what's up with failing tests? Thanks.

Refreshed/ attempting again 🤞🏼 , don't see anything that differs from previous update PR's.

I'm not sure if updates to the version here also need to have a corresponding update with our remote workspace settings, but I don't think I have permissions to check it

t0yv0 commented 1 year ago 
  error: error constructing backend state manager: Remote workspace Terraform version "1.4.5" does not match local Terraform version "1.4.6"

Perhaps skip this test for now, file an issue and we can proceed with it skipped. There seem to be a few other tests so that's good.

aq17 commented 1 year ago

@t0yv0 interesting, so the test is failing for python now (not just dotnet). Okay to skip it in all languages for now, or should we investigate further?

t0yv0 commented 1 year ago

Skip everywhere - we should investigate sometime but on the surface

  error: error constructing backend state manager: Remote workspace Terraform version "1.4.5" does not match local Terraform version "1.4.6"

Makes it look like the issue is with our test environment setup and not with the provider, not an issue that's affecting users, therefore prioritizing unblocking the upgrade.