pulumi / pulumi-tls

A Pulumi provider for TLS resource management
Apache License 2.0
12 stars 3 forks source link

OriginCaCertificate references invalid TLS CertRequest Property `Subjects` #498

Closed phillipedwards closed 6 months ago

phillipedwards commented 6 months ago

What happened?

The example for OriginCaCertificate references an invalid TLS CertRequest property Subjects whereas the property is Subject.

Example

Example in the registry

var exampleCertRequest = new Tls.CertRequest("exampleCertRequest", new()
    {
        PrivateKeyPem = examplePrivateKey.PrivateKeyPem,
        Subjects = new[]
        {
            new Tls.Inputs.CertRequestSubjectArgs
            {
                CommonName = "",
                Organization = "Terraform Test",
            },
        },
    });

Working example (c#)

var exampleCertRequest = new Tls.CertRequest("exampleCertRequest", new()
    {
        PrivateKeyPem = examplePrivateKey.PrivateKeyPem,
        Subject = new Tls.Inputs.CertRequestSubjectArgs
        {
            CommonName = "example.com",
            Organization = "ACME Examples, Inc",
        },
    });

Output of pulumi about

n/a

Additional context

No response

Contributing

Vote on this issue by adding a πŸ‘ reaction. To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

phillipedwards commented 6 months ago

Also!!!! the broken examples references Terraform :/

iwahbe commented 6 months ago

Hey @phillipedwards. Both issues have since been fixed, but we haven't had a release to publish them. I'll kick off a patch release now.