search

pulumi / pulumi-upgrade-provider-action

A composite action for upgrading bridged providers.
Apache License 2.0
2 stars 1 forks source link

Upgrade provider is no longer requesting PR reviews when set in .ci-mgmt.yaml #19

Closed iwahbe closed 1 year ago

iwahbe commented 1 year ago

What happened?

https://github.com/pulumi/pulumi-upgrade-provider-action/pull/18/files sets --pr-reviewers="$REV", which is equivalent to setting --pr-reviewers="" in the default case. This is not the same as not setting --pr-reviewers.

Example

https://github.com/pulumi/pulumi-spotinst/pull/454

Note that assignments were requested manually.

Output of pulumi about

NA

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction. To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

t0yv0 commented 1 year ago

Thanks for spotting this. If we could make --pr-reviewers="" equivalent to not setting --pr-reviewers I'd appreciate it. In addition to being closer to Go dictum on empty/zero values, it seriously eases the YAML programming required in the GitHub Action platform when the CLI arguments need to be lifted to GHA arguments.

iwahbe commented 1 year ago

Fixed by https://github.com/pulumi/pulumi-upgrade-provider-action/pull/20.