pulumi / pulumi-yaml

YAML language provider for Pulumi
Apache License 2.0
39 stars 12 forks source link

Remove S3 public access block in examples #451

Closed AaronFriel closed 1 year ago

AaronFriel commented 1 year ago

This unblocks these examples working as simple static sites. The changes in this commit echo those made in our AWS getting started guide here:

AaronFriel commented 1 year ago

@cnunciato It looks like the BucketPolicy got an AccessDenied, I saw that locally but on my second pulumi up it succeeded. Do I need to add a DependsOn there, too?

Or do we need this policy ACL at all for the example?


  bucketPolicy:
    type: aws:s3:BucketPolicy
    properties:
      bucket: ${site-bucket}
      policy: |
        {
          "Version": "2012-10-17",
          "Statement": [
            {
              "Effect": "Allow",
              "Principal": "*",
              "Action": ["s3:GetObject"],
              "Resource": ["${site-bucket.arn}/*"]
            }
          ]
        }
cnunciato commented 1 year ago

@AaronFriel I'm pretty sure you don't actually need that bucket policy, yeah. Does the example not work without it?