Download error for third party provider is misleading

[jaxxstorm]

What happened?

I am trying to use a YAML program with a third party community provider.

Instead of using the provider url to download, it is reaching out to the Pulumi repo:

 pulumi:pulumi:Stack (aws-accounts-example):
    E1017 11:27:07.867952   47371 log.go:91] GitHub rate limit exceeded for https://api.github.com/repos/pulumi/pulumi-awscontroltower/releases/latest, try again in 59m15.132057s. You can set GITHUB_TOKEN to make an authenticated request with a higher rate limit.
    E1017 11:27:07.903415   47371 log.go:91] GitHub rate limit exceeded for https://api.github.com/repos/pulumi/pulumi-awscontroltower/releases/latest, try again in 59m16.09659s. You can set GITHUB_TOKEN to make an authenticated request with a higher rate limit.

I tried adding the pluginDownloadURL property to the provider with no luck

Example

name: aws-accounts
runtime: yaml
description: A Pulumi YAML program to create an AWS account in AWS Control Tower
resources:
  provider:
    type: pulumi:providers:awscontroltower
    options:
      pluginDownloadURL: "github://api.github.com/lbrlabs"

Output of pulumi about

N/A

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction. To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

[justinvp]

@jaxxstorm, I can't repro this. When I run the above program, it downloads the plugin. From the Slack thread, could it be that you were running into this before a version of that provider was released on GitHub?

[jaxxstorm]

i think this was because the publish hadn't finished, I believe the error is misleading.

[Frassle]

I believe the error is misleading.

Agree'd. If a download URL is given we shouldn't ever be falling back to github.com/pulumi/. Suggests that somewhere along the line the URL got lost.

[jaxxstorm]

I've updated the issue title to better reflect the problem