pulumi / pulumi

Pulumi - Infrastructure as Code in any programming language šŸš€
https://www.pulumi.com
Apache License 2.0
20.46k stars 1.06k forks source link

`pulumi-terraform` tests fail on Pulumi v3.21.0 #16502

Open iwahbe opened 4 days ago

iwahbe commented 4 days ago

What happened?

I was migrating pulumi-terraform off of actions/upload-artifact@v2 and CI failed unexpectedly (unrelated to my change). Investigating showed that CI always fails now, though it succeeded on the last merge to master (3 months ago).

Pinning to v3.108.1 resolved the issue.

Example

Failed workflow: https://github.com/pulumi/pulumi-terraform/actions/runs/9688729320/job/26736002406

The workflow fails with:

  Diagnostics:
    terraform:state:RemoteStateReference (localstate):
      error: Diff is not yet implemented

My suspicion is that we have accidentally made Diff required instead of apply a default. This is a breaking change.

Passing workflow: https://github.com/pulumi/pulumi-terraform/actions/runs/9688978736/job/26736482099

Output of pulumi about

NA

Additional context

Thread in slack: https://pulumi.slack.com/archives/C02VCJEBT2N/p1719449691127099

Contributing

Vote on this issue by adding a šŸ‘ reaction. To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

iwahbe commented 4 days ago

Since the failure is during a pulumi up --refresh, I'm guessing the failure is due to the new diff behavior.