pulumi / registry

The global index of everything you can do with Pulumi.
https://www.pulumi.com/registry
Apache License 2.0
24 stars 110 forks source link

Update index page of Command for GA #4833

Closed thomas11 closed 3 days ago

thomas11 commented 6 days ago

Basically

Regarding the EC2/copy example: it spends about ~22 lines on provisioning an EC2 instance with pulumi-aws, with no usage of Command. I think it might be good to remove that part. I have working code in all languages that assumes the remote server exists and takes its IP as a config.

github-actions[bot] commented 6 days ago

Your site preview for commit 736ce9b4 is ready! :tada:

http://registry--origin-pr-4833-736ce9b4.s3-website.us-west-2.amazonaws.com/registry.

github-actions[bot] commented 6 days ago

Your site preview for commit 3c43bb20 is ready! :tada:

http://registry--origin-pr-4833-3c43bb20.s3-website.us-west-2.amazonaws.com/registry.

github-actions[bot] commented 4 days ago

Your site preview for commit 33dd4f49 is ready! :tada:

http://registry--origin-pr-4833-33dd4f49.s3-website.us-west-2.amazonaws.com/registry.

github-actions[bot] commented 4 days ago

Your site preview for commit 8a09f228 is ready! :tada:

http://registry--origin-pr-4833-8a09f228.s3-website.us-west-2.amazonaws.com/registry.

thomas11 commented 4 days ago

Hey @thomas11, I noticed the chooser was kind of broken and the JS examples didn't quite work, so I took the liberty of pushing a commit to save you the hassle of fixing these things up. Hope that's ok!

Thank you, I appreciate it!

Regarding the EC2/copy example: it spends about ~22 lines on provisioning an EC2 instance with pulumi-aws, with no usage of Command. I think it might be good to remove that part.

I agree -- and what's worse it that the relevant parts aren't even visible in the snippet because it's being cropped. Definitely support swapping this out with something else, but will leave that to you.

I swapped it out. The actual copy and command are still the same.

How about the "Using local.Command with CURL to manage external REST API" example? Do you have code in the other languages for that one?

That's the only one remaining where I don't have code in other languages yet.

github-actions[bot] commented 3 days ago

Site previews for this pull request have been removed. ✨