search

pulumi / templates

Templates used by `pulumi new`
Apache License 2.0
105 stars 66 forks source link

"Run performance metrics" job passes despite failure #505

Open cnunciato opened 1 year ago

cnunciato commented 1 year ago

This job appears to pass even when some templates fail. We should (a) ascertain what this job was intended to do, (b) make sure that's still important to us, and (c) fix or delete the job accordingly.

t0yv0 commented 1 year ago

This was done on purpose, because it currently doesn't publish data for partial failure. From the metrics system POV its' better to get some data than to get none data at all when only one job fails.

CC @kpitzen

cnunciato commented 1 year ago

@t0yv0 Ok thanks. Who's looking at this data? Want to make sure this is still a job worth running.

t0yv0 commented 1 year ago

@justinvp just closed a P1 originating from looking at this data.