search

pulumi / upgrade-provider

A tool to automate provider upgrades on your local machine
6 stars 1 forks source link

Signalfx major upgrade left provider out of sync with ci-mgmt #165

Closed t0yv0 closed 10 months ago

t0yv0 commented 1 year ago

What happened?

This update https://github.com/pulumi/pulumi-signalfx/pull/272

left it on v7 vs v6.

This in turn caused https://github.com/pulumi/ci-mgmt/issues/622 p1

This is pretty unfortunate. What's the plan here, should we move the major version number out of ci-mgmt and into repo? That feels like something that could really help here.

Example

N/A

Output of pulumi about

N/A

Additional context

N/A

Contributing

Vote on this issue by adding a 👍 reaction. To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

mikhailshilkov commented 1 year ago

I believe this is not currently handled in the upgrade tool. Do you think it should be? Or should we move this issue to ci-mgmt?

t0yv0 commented 1 year ago

Yeah I'm open ideas where to handle this; mostly filing to rethink later. The current process is broken because one automation breaks another automation, by design. This needs fixing.

Perhaps one fix would be to move major version out of ci-mgmt and into a config file in each provider repo.

iwahbe commented 10 months ago

Since this issue was opened, the major version of the provider is now stored in .ci-mgmt.yaml in the provider. It is now conceivable that upgrade-provider can do the major version in 1 PR.

t0yv0 commented 10 months ago

Yes, I can confirm using .ci-mgmt.yaml to move around in pulumi-gcp with great ease. I consider this fixed.

pulumi-bot commented 10 months ago

Cannot close issue:

Please fix these problems and try again.