pulumi / upgrade-provider

A tool to automate provider upgrades on your local machine
6 stars 1 forks source link

setting `--target-pulumi-version` not regenerating SDKs #199

Closed dixler closed 11 months ago

dixler commented 11 months ago

What happened?

https://github.com/pulumi/pulumi/pull/14561 dispatches an upgrade-bridge workflow on pulumi-aws specifying the pulumi version.

https://github.com/pulumi/pulumi-aws/pull/2989

It should regenerate the SDKs, but does not.

Example

-

Output of pulumi about

-

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction. To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

iwahbe commented 11 months ago

It looks like this does regenerate SDKs:

Local Workflow run ``` 𝛌 upgrade-provider pulumi/pulumi-aws --kind=bridge --pr-reviewers=iwahbe --target-pulumi-version=5f16ea185be699297c430b65e96176fab2d0bd0d ---- Setting Up Environment ---- - ✓ GOWORK="off": done - ✓ PULUMI_MISSING_DOCS_ERROR="true": done - ✓ PULUMI_CONVERT_EXAMPLES_CACHE_DIR="": done --- Discover Provider --- - Ensure Upstream Repo - Expected Location: /Users/ianwahbe/go/src/github.com/pulumi/pulumi-aws - GetCwd: /Users/ianwahbe/go/src/github.com/pulumi/pulumi-aws - Repo Exists - Stat - Validate Repository - git: /opt/homebrew/bin/git status --short --- done --- ---- Discovering Repository ---- - pull default branch - ✓ /opt/homebrew/bin/git ls-remote --heads origin: done - ✓ finding default branch: master - ✓ /opt/homebrew/bin/git fetch: done - ✓ /opt/homebrew/bin/git checkout master: done - ✓ /opt/homebrew/bin/git pull origin: done - ✓ Repo kind: patched - ✓ Planning Bridge Update: Up to date at v3.65.0 - ✓ Planning Plugin SDK Update: Up to date at 2.29.0 - ✓ Planning Plugin Framework Update: Up to date at 0.19.0 --- Setup working branch --- - Working Branch Name: upgrade-pulumi-version-to-5f16ea185be699297c430b65e96176fab2d0bd0d - Ensure Branch - git: /opt/homebrew/bin/git branch - git: /opt/homebrew/bin/git checkout -b upgrade-pulumi-version-to-5f16ea185be699297c430b65e96176fab2d0bd0d - Has Remote Branch: no - gh: /opt/homebrew/bin/gh pr list --json=title,headRefName --- done --- ---- Update Repository ---- - ✓ /usr/bin/make upstream: done - Upgrade Pulumi Version - provider - ✓ /opt/homebrew/bin/go mod edit -replace github.com/pulumi/pulumi/pkg/v3=github.co...: done - ✓ /opt/homebrew/bin/go mod tidy: done - examples - ✓ /opt/homebrew/bin/go mod edit -replace github.com/pulumi/pulumi/pkg/v3=github.co...: done - ✓ /opt/homebrew/bin/go mod tidy: done - sdk - ✓ /opt/homebrew/bin/go mod edit -replace github.com/pulumi/pulumi/pkg/v3=github.co...: done - ✓ /opt/homebrew/bin/go mod tidy: done --- Tfgen & Build SDKs --- - go: /opt/homebrew/bin/go mod tidy - go: /opt/homebrew/bin/go mod tidy - go: /opt/homebrew/bin/go mod tidy - pulumi: /Users/ianwahbe/go/bin/pulumi plugin rm --all --yes - make: /usr/bin/make tfgen - git: /opt/homebrew/bin/git add --all - git commit - git: /opt/homebrew/bin/git status --porcelain=1 - git: /opt/homebrew/bin/git commit -m make tfgen - make: /usr/bin/make build_sdks - git: /opt/homebrew/bin/git add --all - git commit: make build_sdks: nothing to commit - git: /opt/homebrew/bin/git status --porcelain=1 - Inform Github - git: /opt/homebrew/bin/git push --set-upstream origin upgrade-pulumi-version-to-5f16ea185be699297c430b65e96176fab2d0bd0d --force - gh: /opt/homebrew/bin/gh pr create --assignee @me --base master --head upgrade-pulumi-version-to-5f16ea185be699297c430b65e96176fab2d0bd0d --reviewer iwahbe --title Test: Upgrade pulumi/{pkg,sdk} to 5f16ea185be699297c430b65e96176fab2d0bd0d --body This PR was generated via `$ upgrade-provider pulumi/pulumi-aws --kind=bridge --pr-reviewers=iwahbe --target-pulumi-version=5f16ea185be699297c430b65e96176fab2d0bd0d`. --- --- done --- ```

@dixler Is it possible that this SHA doesn't have a codegen effect?

It seems like other SHAs do have a codegen effect, for example https://github.com/pulumi/pulumi-aws/pull/3005.

iwahbe commented 11 months ago

Closing as no-repro.