Create upgrade labels when necessary

pulumi / upgrade-provider

A tool to automate provider upgrades on your local machine

7 stars 1 forks source link

Create upgrade labels when necessary #205

Open iwahbe opened 1 year ago

iwahbe commented 1 year ago

Hello!

Vote on this issue by adding a 👍 reaction
If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

When an upgrade is indicates, upgrade-provider needs to apply the label to trigger the upgrade on PR merge. Labels added are needs-release/patch, needs-release/minor and needs-release/major.[^1] If label does not exist on the provider and needs to be created, the upgrade fails: https://github.com/pulumi/pulumi-rke/actions/runs/6935929271/attempts/1.

We should solve this by:

Standardizing the list of provider labels and making sure the release labels are included, or
Creating the labels if they don't already exist within upgrade-provider.

Affected area/feature

iwahbe commented 1 year ago

The same issue just blocked https://github.com/pulumi/pulumi-spotinst/actions/runs/6946256008/attempts/1.

iwahbe commented 10 months ago

The urgency here is very low, since this was resolved upstream by https://github.com/pulumi/ci-mgmt/pull/757.

ringods commented 7 months ago

This issue makes upgrade-provider not usable outside of Pulumi.

https://github.com/pulumiverse/pulumi-acme/actions/runs/8778868034/job/24085996153#step:2:661

iwahbe commented 7 months ago

I'll take a look here. As with all of our partially internal tools, we need to create a clear distinction between what needs a pulumi specific setup and what should be usable in any repo.

danielrbradley commented 1 month ago

Instead of hard erroring, could we at least just warn that these labels don't exist but exit cleanly?

Ideally, attempting to create them would be nice too though.

ringods commented 1 month ago

@danielrbradley from your two options above, I would prefer to generate a warning. Attempting to create these labels could still error out if the user's Github token doesn't have permissions to create labels.

t0yv0 commented 1 month ago

Would this help instead ? https://github.com/pulumi/provider-version-action/issues/13

danielrbradley commented 1 month ago

Would this help instead ? https://github.com/pulumi/provider-version-action/issues/13

Don't think so. The issue is just that if a third party repo hasn't set up the needs-release labels then the upgrade tool will always fail.

That issue is interesting though, and I'd like to see it implemented 👍