pulumi / upgrade-provider

A tool to automate provider upgrades on your local machine
7 stars 1 forks source link

`go.Mod.UpstreamProviderOrg` is unreliable and misleading #213

Closed guineveresaenger closed 11 months ago

guineveresaenger commented 11 months ago

What happened?

For the new upstream upgrade check we use go.Mod.UpstreamProviderOrg to detect upstream releases.

However, the way that field gets populated is by attempting to read the upstream provider from the provider/go.mod file, which:

This behavior is correct for "typical" providers with no renames, replaces, or otherwise obscuring the link to the GitHub org/repo location of the upstream provider, so it "works" in those instances.

The reason we did not detect this bug sooner is that we did not ever actually use the go.Mod.UpstreamProviderOrg before attempting to discover upstream upgrades.

Example

https://github.com/pulumi/pulumi-gitlab/issues/445

Output of pulumi about

n/a

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction. To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).