search

pulumi / upgrade-provider

A tool to automate provider upgrades on your local machine
6 stars 1 forks source link

Enable gci linter with automatic fix. Apply lint fixes. #236

Closed guineveresaenger closed 8 months ago

guineveresaenger commented 8 months ago

If we want to standardize import grouping and sorting, we should enforce it in code.

guineveresaenger commented 8 months ago

Do we have these standards documented somewhere? I looked into it and we can definitely configure custom rules.

iwahbe commented 8 months ago

Do we have these standards documented somewhere? I looked into it and we can definitely configure custom rules.

Not that I'm aware of. I see two patterns in our code bases:

  1. The one that I mentioned above. (example)
  2. A variation, where there is an additional block for github.com/pulumi/*. (example)

I'm fine with either.