pulumi / upgrade-provider

A tool to automate provider upgrades on your local machine
7 stars 1 forks source link

Do not upgrade forked terraform-plugin-sdk ahead of the bridge #243

Closed t0yv0 closed 9 months ago

t0yv0 commented 9 months ago

What happened?

Per conversation in https://github.com/pulumi/upgrade-provider/pull/242/files it appears that maybe/possibly we're upgrading the fork of terraform-plugin-sdk to the latest from GitHub. That's may be a good option to have but it's not a good default. By default we should be trying to match whatever the bridge has when upgrading the bridge, because that is the version the bridge was tested with. Unfortunately go tooling does not make this trivial, but something along the lines of finding bridge sources and finding the go mod replace directive from those sources that the bridge was built with could do the trick. If helpful we can lift this to a text file in the bridge somehow.

Example

N/A

Output of pulumi about

N/A

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction. To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

t0yv0 commented 9 months ago

https://github.com/pulumi/pulumi-gcp/pull/1638/files#diff-0301265a2d4321ca487bbd7ba523f69633171cef680c0114e7ca8d2c34176b73R19 another one.. I was updating GCP to do a simple minor update and looks like the terraform-plugin-sdk is updating as part of it. That's a bit suspect.

t0yv0 commented 9 months ago

OK this is causing failure to pre-test bridge upgrade with a given sdk version

--target-bridge-version: 45cdb2507f387f34af187ca4021076549cbbf78e

https://github.com/pulumi/pulumi-github/issues/559 and more