search

pulumi / upgrade-provider

A tool to automate provider upgrades on your local machine
6 stars 1 forks source link

Clear examples cache during major upgrades #275

Closed guineveresaenger closed 1 month ago

guineveresaenger commented 2 months ago

Update: Apologies for the delay here; see https://github.com/pulumi/pulumi-terraform-bridge/issues/2323.

https://github.com/pulumi/pulumi-confluentcloud/pull/559 failed because the upgrade process was using an old examples cache locally. As a result, the Go SDK was generated with old version paths in the examples code, which failed the Clean Worktree check. The upgrade-provider tool should remove the cache to ensure we're generating examples correctly.

t0yv0 commented 2 months ago

Suggest fixing in the bridge instead since some interaction happens via make tfgen instead of via upgrade-provider, that'd be more definitive.

guineveresaenger commented 2 months ago

@t0yv0 - reasonable! I see you found https://github.com/pulumi/pulumi-terraform-bridge/issues/2323 already.

t0yv0 commented 2 months ago

I'm with Daniel, ship the workaround. We'll fix the root cause later.