search

pulumiverse / pulumi-grafana

Pulumi provider for Grafana
Apache License 2.0
19 stars 10 forks source link

OrgId is mandatory in RuleGroup while it is not in Terraform #110

Open guifran001 opened 8 months ago

guifran001 commented 8 months ago

In the documentation, most of the resources can take a OrgId as input documented like that:

The Organization ID. If not set, the Org ID defined in the provider block will be used.

But OrgId is mandatory for RuleGroup and enforced here: https://github.com/lbrlabs/pulumi-grafana/blob/5561b3334f91460d165fb2ac938857086a0f443a/sdk/go/grafana/ruleGroup.go#L180

But on the terraform side, it is optional: https://github.com/grafana/terraform-provider-grafana/blob/f2a3013f6cd24acfcc27fe95b020190c316bf95a/internal/resources/grafana/oss_org_id.go#L18

Since the SDK code is generated, I do not understand where the code ensuring that it is not nil comes from. Therefore, I cannot provide a pr for a fix. I understand now: Terraform made the change not long ago: https://github.com/grafana/terraform-provider-grafana/commit/f3b1845a2516a9b9301212efb5c95373458eadf1

Is the update of the terraform provider is automated and can be triggered or a pull request must be opened ?

guifran001 commented 8 months ago

From what I'm seeing, it would be fixed by pr #103

CyberArkCH3 commented 7 months ago

Any movement on this request?

ringods commented 4 months ago

@guifran001 @CyberArkCH3 can you retry with version v0.4.0 (or later) and report back if it solves your problem?