search

pulyaevskiy / firebase-admin-interop

Firebase Admin Interop Library for Dart
BSD 3-Clause "New" or "Revised" License
80 stars 37 forks source link

implement database Query.on() function #39

Closed m1-nann closed 5 years ago

m1-nann commented 5 years ago

I also added a return of Function, which is used to unsubscribe the .on, instead of having to use .off

pulyaevskiy commented 5 years ago

Hey, just checking in if you're still planning to finalize this PR? It's ok if not, I will likely have some time over the weekend to get this finished.

m1-nann commented 5 years ago

Hey sorry. I was thinking that this PR is only for .on method. I was thinking the .off method was complex (handling a List to off every single Subscription for the first and 2nd cases...). But I realized just I was overthinking just now. Let me include it.

pulyaevskiy commented 5 years ago

Hey sorry. I was thinking that this PR is only for .on method. I was thinking the .off method was complex (handling a List to off every single Subscription for the first and 2nd cases...). But I realized just I was overthinking just now. Let me include it.

No worries. It would definitely make sense to have off here as well as it completes the overall feature. Thanks again for working on this!

m1-nann commented 5 years ago

Hi, wondering if the lastest commit alright?

pulyaevskiy commented 5 years ago

Version 1.2.0 is out which includes this change.