not to use new keyword anymore, and clean them out for next release?

pulyaevskiy / firebase-admin-interop

Firebase Admin Interop Library for Dart

BSD 3-Clause "New" or "Revised" License

79 stars 37 forks source link

not to use new keyword anymore, and clean them out for next release? #41

Open m1-nann opened 5 years ago

m1-nann commented 5 years ago

I know it's optional, but should we put this on plan? new keyword is discourage in Dart Usage guideline as well:

https://www.dartlang.org/guides/language/effective-dart/usage#dont-use-new

pulyaevskiy commented 5 years ago

You're right, this needs to be cleaned up.

I haven't done this yet because analyzer had an issue with handling Map objects in Dart 2.0 so I just left it as is, it might have changed in 2.1 though.