search

pulyaevskiy / firebase-functions-interop

Firebase Functions Interop Library for Dart.
BSD 3-Clause "New" or "Revised" License
191 stars 52 forks source link

Add Pubsub support #10

Closed Cretezy closed 6 years ago

Cretezy commented 6 years ago

Support Pubsub. Untested but should work.

Cretezy commented 6 years ago

Alright, made a new commit changing it back to PubsubEvent.

pulyaevskiy commented 6 years ago

I'm going to hold off from reviewing this for now, just let me know when it's ready for another round.

Cretezy commented 6 years ago

Should be fine now. It compiles on both dart2js and DDC for me. I'm not sure how to make the test though. Let me know if there's anything else to be done.

Cretezy commented 6 years ago

Should be good now, I went over all the changes. Thank you for helping me! I'm starting to get a much better grasp on the library (and Dart, this is literally my first day using it!)

pulyaevskiy commented 6 years ago

LGTM! Must say this is impressive for a first-day Dart user. 👍

Merging this PR and will take a look at testing. Most likely will publish to Pub sometime tomorrow.