search

pulyaevskiy / firebase-functions-interop

Firebase Functions Interop Library for Dart.
BSD 3-Clause "New" or "Revised" License
191 stars 52 forks source link

Add tests #2

Closed kevmoo closed 6 years ago

kevmoo commented 7 years ago

Mostly opening this as an FYI

Will be much easier very soon – https://github.com/dart-lang/test/pull/663 😄

pulyaevskiy commented 7 years ago

Nice, thanks! And yes, tests are in progress. I wanted to see if I can write an integration test against Firebase itself (for more confidence) and realized I'll need firebase_admin_interop for https://github.com/firebase/firebase-admin-node to verify database triggers. So building a PoC for it now.

marcinsydor commented 7 years ago

I've started testing your package. Work very well for me so far. The good news about firebase_admin package. Can you say approximately when we will be able to test it?

pulyaevskiy commented 7 years ago

@kevmoo Thanks again for the hint! I upgraded node_interop to use --platform node and it works great! There are a couple things I'm struggling with though, like expecting for console.log() to print something...

@marcinsydor Thanks for the feedback! I've just published a very-very barebones version here: https://pub.dartlang.org/packages/firebase_admin_interop

Also using updated test package to run integration tests. Looking forward for your feedback!

Next in line for tests is this package.

marcinsydor commented 6 years ago

Great, seems to work fine for me. I'm trying now to return some values from the database but DataSnapshot doesn't have forEach function yet. If you not going to add it soon I guess I could add it myself?

pulyaevskiy commented 6 years ago

I'm slowly getting back to work on this and other Dart related projects.

I've added a few tests since then and there is basic infrastructure for integration testing, however I'm not exactly sure how to solve an issue with Travis removing env vars for PR builds which breaks integration tests. Will do some research on that.

The new --platform=node makes things a lot easier though, very happy with it!

kevmoo commented 6 years ago

Great to hear!

pulyaevskiy commented 6 years ago

Closing this one as there are some tests now. Can still do better on testing side, but let's track updates/improvements in separate issues.