Add toJson

[pulyaevskiy]

FYI: Build fails because I have encrypted environment variables to configure Firebase account and Travis removes them for PR builds.

[kevmoo]

FYI: Build fails because I have encrypted environment variables to configure Firebase account and Travis removes them for PR builds.

Understood. I often create a one-off branch for 3rd-party PRs to validate such things...

[kevmoo]

:-)

On Tue, Sep 12, 2017 at 3:08 PM, Anatoly Pulyaevskiy < notifications@github.com> wrote:

@pulyaevskiy commented on this pull request.

In lib/src/database.dart https://github.com/pulyaevskiy/firebase-functions-interop/pull/4#discussion_r138479413 :

@@ -133,14 +135,7 @@ class Reference { Future set(dynamic value) { var jsValue = jsify(value);

• // Firebase calls onComplete with two arguments even though it's documented
• // as only accepting one.
• void onComplete(error, undocumented) {
• print(
• 'Completed with error "$error" and undocumented param "$undocumented"');
• }
• var promise = _inner.set(jsValue, js.allowInterop(onComplete));

Thanks for removing the callback!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pulyaevskiy/firebase-functions-interop/pull/4#pullrequestreview-62280931, or mute the thread https://github.com/notifications/unsubscribe-auth/AABCiotLkyiYugBCHl_TNmJbBa5J-nSwks5shwDIgaJpZM4PVRdU .

[pulyaevskiy]

Thanks @kevmoo ! https://pub.dartlang.org/packages/firebase_functions_interop/versions/0.0.3-dev

[kevmoo]

Awesome! FYI – it's good to strip the '-dev' off before releasing.

I put that there so you could make sure you didn't want to make other changes after my commit.

On Thu, Sep 14, 2017 at 7:19 PM, Anatoly Pulyaevskiy < notifications@github.com> wrote:

Thanks @kevmoo https://github.com/kevmoo ! https://pub.dartlang.org/packages/firebase_functions_ interop/versions/0.0.3-dev

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pulyaevskiy/firebase-functions-interop/pull/4#issuecomment-329659874, or mute the thread https://github.com/notifications/unsubscribe-auth/AABCikhsJrOe0akVnk9wbaeoDkM-1kweks5sid6UgaJpZM4PVRdU .

[pulyaevskiy]

Thanks, good to know! Curious if there any guidelines for versioning specific to Pub (except semver itself)?

[kevmoo]

Just semver.

Bump the major version if there are breaking changes.

If you're pre v1, then the major version jumps back one.

So 0.1.0 to 0.1.1 – non-breaking change – but new feature 0.1.0 to 0.2.0 – breaking change

On Thu, Sep 14, 2017 at 10:08 PM, Anatoly Pulyaevskiy < notifications@github.com> wrote:

Thanks, good to know! Curious if there any guidelines for versioning specific to Pub (except semver itself)?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pulyaevskiy/firebase-functions-interop/pull/4#issuecomment-329682724, or mute the thread https://github.com/notifications/unsubscribe-auth/AABCiiOfqUWf5ZHgdqaIcIgMCHDkGERmks5sigY2gaJpZM4PVRdU .