search

pulyaevskiy / firebase-functions-interop

Firebase Functions Interop Library for Dart.
BSD 3-Clause "New" or "Revised" License
191 stars 52 forks source link

Possiblity fix tests #9

Closed Cretezy closed 6 years ago

Cretezy commented 6 years ago

I'm unsure if this will work. Travis reports a file not found when doing ./tool/deploy.sh so it's better to be safe and use sh to run the file.

pulyaevskiy commented 6 years ago

Sorry, I should've mentioned this somewhere in the docs. Travis builds from feature branches will always fail because of protected env vars used in the build. Your first PR tests passed in the master after I merged it.

I haven't figured out how to make it work for PRs yet. But in general if you run tests locally and everything looks good it should be ok.

Cretezy commented 6 years ago

Alright makes sense! I've still pushed a new commit that cleans up the thing and makes it compatible with using the main field in the package.json

pulyaevskiy commented 6 years ago

LGTM, thanks again!