search

puma / puma-dev

A tool to manage rack apps in development with puma
BSD 3-Clause "New" or "Revised" License
1.74k stars 107 forks source link

Fix: sharing app instances with different hostnames not working #281

Closed jorgemanrubia closed 3 years ago

jorgemanrubia commented 3 years ago

This fixes a problem where it fails to reuse the same instance of the app when using multiple hostnames with different names (multiple symlinks pointing to the same folder).

The bug was introduced in #270. The patch is based on adding the checksum in all cases when a symlink is involved, not only when the names don't match. If not, it can happen that it's not added if the name matches for the first execution, which results in not finding the app instance later, resulting in an error "There is already a server bound to..."

Fixes #280

cc @hellvinz @nonrational

nonrational commented 3 years ago

Thanks @jorgemanrubia!

jorgemanrubia commented 3 years ago

Thanks for merging @nonrational. Any chance we can get a brew release with this one 🙏?

nonrational commented 3 years ago

@jorgemanrubia v0.16.1 is now available at puma/puma/puma-dev 👍

jorgemanrubia commented 3 years ago

Thank you @nonrational 🙏🙏