consugus
commented
7 years ago Hi @emravera, @nestornav. In the package.json there's a place where dependencies are specified, which I've edited in the second commit. For example, there it says: "dependencies":{ "bootstrap": "^3.3.7", "codemirror": "^5.18.2", "jquery": "^1.9.1" The character "^" before de version number indicates npm to install this specific version or any newer stable version available. The result is that npm installs
- bootstrap v3.3.7 (it seems to be the the newest one)
- codemirror v5.30.0
- jquery v 1.12.4 It was necessary to modify the path for jquery as this new version places the jquery.min.js in another folder. All that was controlled and everything (as far as I could check) was running ok.
Hope I can take care of the other comments soon. Regards,
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Libre de virus. www.avast.com https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#m_-1523389908543990745_DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
2017-09-26 10:23 GMT-03:00 Emanuel Ravera notifications@github.com:
@emravera commented on this pull request.
Looks good to me the only comment is to check if we can find newer versions for the libraries.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pumascript/puma/pull/100#pullrequestreview-65211695, or mute the thread https://github.com/notifications/unsubscribe-auth/ALehGZBOYInujLEx97X09tDYoJKiwsG6ks5smPrlgaJpZM4PhXFe .
-- Gustavo Jorge Ríos Tel: +54 (351) 456-0048 Móvil: +54 (351) 155 74-2658 Enviado desde Gmail On-Line
emravera
Here are all the changes needed to complete issue #93: Migrate Bower dependencies to NPM. With this changes all three dependencies Bootstraps, JQuery and Codemirror are called through npm using the package.json file. All other files have been modified so any user can call "grunt init" to have all dependencies installed in his system. No modification to the .gitignore was needed as npm_modules folder was already excluded from being uploaded to the repository