search

pump-io / pump.io

Social server with an ActivityStreams API
http://pump.io/
Apache License 2.0
2.21k stars 334 forks source link

Consider moving to ESLint #1177

Open strugee opened 7 years ago

strugee commented 7 years ago

ESLint is a next-gen ECMAScript checker that can do both JSCS-style (read: style) and JSHint-style (read: correctness) checks.

Note that JSCS is deprecated in favor of ESLint.

grdryn commented 7 years ago

+1 to ESLint. The CLI tool is able to automatically fix certain types of violations with --fix (although not all...but I guess it depends on which rules are put in the .eslintrc file).

strugee commented 7 years ago

We need @evanp's input on this.

bernhardreiter commented 7 years ago

Good about ESLint is that it is Free Software (jslint and jshint are non-free).

strugee commented 7 years ago

@bernhardreiter not sure what you're talking about. JSHint is MIT-licensed.

bernhardreiter commented 7 years ago

@strugee see https://github.com/jshint/jshint/blob/master/README.md

Most files are published using the standard MIT Expat license. One file, however, is provided under a slightly modified version of that license. The so-called JSON license is a non-free license, and unfortunately, we can't change it due to historical reasons.