pump-io / pump.io

Social server with an ActivityStreams API
http://pump.io/
Apache License 2.0
2.21k stars 332 forks source link

An in-range update of proxyquire is breaking the build 🚨 #1544

Open greenkeeper[bot] opened 6 years ago

greenkeeper[bot] commented 6 years ago

☝️ Greenkeeper’s updated Terms of Service will come into effect on April 6th, 2018.

Version 2.0.1 of proxyquire was just published.

Branch Build failing 🚨
Dependency proxyquire
Current Version 2.0.0
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

proxyquire is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details - ❌ **continuous-integration/travis-ci/push** The Travis CI build failed [Details](https://travis-ci.org/pump-io/pump.io/builds/355609614?utm_source=github_status&utm_medium=notification) - ✅ **coverage/coveralls** First build on greenkeeper/proxyquire-2.0.1 at 44.171% [Details](https://coveralls.io/builds/16063696)

Commits

The new version differs by 3 commits.

  • 58a6321 2.0.1
  • 851baaa Clean up proxyquired module after restoring cache
  • d3a155d Update to resolve@1.5 (#194)

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 6 years ago

After pinning to 2.0.0 your tests are passing again. Downgrade this dependency 📌.

strugee commented 6 years ago

Fixed in aa77062c but I'd like to leave this open as we'll want to file a bug on this upstream.