search

pump-io / pump.io

Social server with an ActivityStreams API
http://pump.io/
Apache License 2.0
2.22k stars 333 forks source link

Show all N replies does not show all N replies #775

Open evanp opened 11 years ago

Screwtapello commented 11 years ago

As a concrete example, if I go to https://pumpdog.me/andyc/note/N86P92zwQx6mmiz5LOPUwg and click "Show all 8 replies", Firefox's Network panel shows two requests to:

Both requests obtain the same result: 500 Internal Server Error, with a response body that looks like this:

NotInStreamError: id '{"id":"https://e14n.com/api/comment/G_bsuhCFRWe1ucG__VDotg","objectType":"note"}' not found in stream 'activityobject:replies:https://pumpdog.me/api/note/N86P92zwQx6mmiz5LOPUwg'
at Function.<anonymous> (/opt/pump.io/lib/model/stream.js:625:26)
at next (/opt/pump.io/node_modules/step/lib/step.js:51:23)
at Function.<anonymous> (/opt/pump.io/lib/model/stream.js:595:29)
at next (/opt/pump.io/node_modules/step/lib/step.js:51:23)
at /opt/pump.io/node_modules/databank/node_modules/databank-mongodb/node_modules/databank/lib/databank.js:334:21
at /opt/pump.io/node_modules/databank/node_modules/databank-mongodb/lib/mongodb.js:363:21
at /opt/pump.io/node_modules/databank/node_modules/databank-mongodb/node_modules/mongodb/lib/mongodb/collection.js:1010:5
at Cursor.nextObject (/opt/pump.io/node_modules/databank/node_modules/databank-mongodb/node_modules/mongodb/lib/mongodb/cursor.js:653:5)
at commandHandler (/opt/pump.io/node_modules/databank/node_modules/databank-mongodb/node_modules/mongodb/lib/mongodb/cursor.js:635:14)
at null.<anonymous> (/opt/pump.io/node_modules/databank/node_modules/databank-mongodb/node_modules/mongodb/lib/mongodb/db.js:1709:18)
Screwtapello commented 11 years ago

Actually, it may be relevant that I'm not logged in to pumpdog.me there (although the post is marked as "To: Public"). That post also shows up in my feed on identi.ca (where I am logged in), but the behaviour is different: Firefox's Network panel shows a near-infinite series of identical-looking requests to https://identi.ca/api/proxy/6oTlEtkMSkiWhTAyHXAYfQ?before=https://io.patrickhaverkamp.com/api/comment/6eMdU6ZyQnaEaKJCV0kctg&count=8 until it eventually gets a 500 Internal Server Error response with a JSON payload containing the message "Unable to retrieve proxy data."

evanp commented 11 years ago

I had a bug in the API for getting earlier/later replies. It's fixed now, I think.

evanp commented 11 years ago

No, it's still there.