pumpikano / tf-dann

Domain-Adversarial Neural Network in Tensorflow
MIT License
628 stars 224 forks source link

Licence #33

Closed albertz closed 2 years ago

albertz commented 2 years ago

Thank you for this nice project!

We (RETURNN) have made use of some code snippets from this project, esp the FlipGradientBuilder. (Or rather, after reading your code, I was not really sure how to write it in a different way.)

Is it possible that you add a licence to your code? Like Apache-2.0 or MIT?

https://github.com/rwth-i6/returnn/issues/796

pumpikano commented 2 years ago

Certainly, this was a oversight from the beginning. I've added MIT license.

I would point out that this implementation may not be the best way to implement flip gradient with the modern TF API. You may want to look at tf.custom_gradient https://www.tensorflow.org/api_docs/python/tf/custom_gradient, though I haven't used it myself.

All the best.

albertz commented 2 years ago

Thanks a lot!