pumpitupdev / pumptools

A collection of tools to run Pump It Up games.
The Unlicense
22 stars 7 forks source link

mk3hook.so: 07_extra no longer working since 1.10 #45

Open concubidated opened 2 years ago

concubidated commented 2 years ago

Bug report

Description

A user reported 07_extra not having any IO when using a PIUIO, when testing I experienced the same issue.

I downgraded pumptools to 1.09. IO started working again, with 1.10 or higher, IO is not working. Nothing really different in the logs I can see.

Affected games and versions

07_extra

Pumptools versions tested

Working: 1.08 1.09

Not working: 1.10 1.11 1.12 master

OS and hardware specs

voidderef commented 2 years ago

I briefly skimmed the history between 1.09 and 1.10 and noticed the major chunk of changes around piuio emulation and API. Seems like the main reason was work on emulating the infamous kernel hack that was required for pro1/pro2.

The issue sounds simple to re-produce and needs to be further scoped to the commit level eventually.

Leaving the above thoughts as notes either for me when i pick this up or if someone else wants to pick this up for a debugging session.

concubidated commented 2 years ago

This commit is the culprit

https://github.com/pumpitupdev/pumptools/commit/7f1a0b075b10f51e547e7d9d73ae130a860928aa