search

punassuming / ranger.el

Bringing the goodness of ranger to dired!
699 stars 52 forks source link

Add option: ranger-travel-use-counsel #141

Open dieggsy opened 7 years ago

dieggsy commented 7 years ago

ranger-travel uses counsel instead of helm if counsel is available and this option is set to t.

punassuming commented 7 years ago

Sorry for the delay. I don't think it needs a variable. Lets just place this cond below the (featurep 'helm) cond and we should be good.

dieggsy commented 7 years ago

Well, that would be fine, but some people might use both helm and counsel (I don't personally), which is why I thought the option might be nice - so it the user has the option, rather than it defaulting to the first package chosen in the code.

braham-snyder commented 7 years ago

+1 -- I generally prefer counsel/ivy as well, but I currently have helm installed incidentally as a dependency of org-ref (though it additionally lists ivy as a dependency, which is a bit odd--I haven't looked into this yet).

edit: regarding org-ref, it currently requires helm even when actually used with only ivy due to complications with MELPA packaging: https://github.com/jkitchin/org-ref/issues/231

edit 2: would just read-file-name work after the user has run helm-mode (through completing-read-function)? or does that exclude some additional helm functionality? it works well for ivy when using ivy-mode

punassuming commented 7 years ago

@braham-snyder , I will try with read-file-name to see if that meets all of our needs. I don't have any added functionality yet.