No preview on directories and many errors

punassuming / ranger.el

Bringing the goodness of ranger to dired!

700 stars 52 forks source link

No preview on directories and many errors #144

Closed Somelauw closed 7 years ago

Somelauw commented 7 years ago

When on a directory, the preview window remains blank.

I also get some errors:

void-function dired-mark-unmarked-files (when trying to preview a directory)
void-variable bookmark-alist (when entering a dictionary)
wrong-type-argument window-valid-p #<window 30> (when toggling preview)
void-variable ranger-pre-header-format (when previewing an org file)

punassuming commented 7 years ago

@Somelauw , can you give some more details on these issues?

What is you build? Does it happen in every folder? Can you give a backtrace on any of these issues?

Somelauw commented 7 years ago

Emacs 24.5.1 using the spacemacs distribution.

Debugger entered--Lisp error: (void-variable ranger-pre-header-format)
  ranger-revert-appearance(#<buffer *spacemacs*>)
  ranger-revert()
  ranger-disable()
  ranger-close()
  call-interactively(ranger-close nil nil)
  command-execute(ranger-close)

Following the instructions in this issue https://github.com/syl20bnr/spacemacs/issues/8360, I added:

(require bookmark)

After doing so, all errors seem to have disappeared.

punassuming commented 7 years ago

Can you try updating the package on melpa? I updated yesterday and explicitly required bookmark.

Somelauw commented 7 years ago

@ralesi thanks. I have updated it and no longer need to require bookmark myself.