search

punassuming / ranger.el

Bringing the goodness of ranger to dired!
699 stars 52 forks source link

Update README.md: groupped keys/typos/etc. #160

Closed duianto closed 7 years ago

duianto commented 7 years ago

Questions:

1: In the todo section, the following line:

  • Work with flattened subdirs and tree

seems to end abruptly, what should it say?

2: The variables:

(setq ranger-parent-header-func 'ranger-parent-header-line)
(setq ranger-preview-header-func 'ranger-preview-header-line)

can only be found in README.md, they are not defined in ranger.el. If they are planned future features, then they probably should be added when that functionality has been implemented.

Should i remove them?

3: The variable: ranger-max-preview-size shows 10 in the README.md, but in ranger it's set to 2.

Should all variables values match their current values in ranger?

4: V isn't bound in ranger.el, but it's listed in README.md as:

V           | visually select lines

It seems to just call the command that V is currently bound to. For example, when Emacs is started with the -Q argument and ranger is loaded. Then V is bound to the default emacs command self-insert-command. But if evil-mode also is loaded then V is bound to evil-visual-line.

With evil-mode enabled and ranger open, then the current line gets selected, but when one tries to move the cursor to the previous or next line, then the selection doesn't extend.

I removed it's entry from README.md.

If i have missed what V is used for, should I can add it back?

punassuming commented 7 years ago

Thanks for checking the README file. I would have to say I have not been doing a good job updating this as new features are being implemented, so I appreciate your work.