search

punchcard-cms / punchcard

The Punchcard CMS
Apache License 2.0
31 stars 19 forks source link

Hotfix/put upload #639

Closed scottnath closed 7 years ago

scottnath commented 7 years ago

Fixes four bugs I found. See #638 for bug details.

Note: probably easier to review if you review each commit separately.

Resolves #638

DCO 1.1 Signed-off-by: Scott Nath <github@scottnath.com>

scottnath commented 7 years ago

@Snugug checking in to see if you have time to review.

note: moving forward with possible use of punchcard in an internal project - if you cannot review this or others, we need to come up with an alternative review process for PRs in Punchcard

Snugug commented 7 years ago

Sorry about the delay, forgot you had requested a review. Just ping me if I forget again

scottnath commented 7 years ago

@Snugug no biggie on delay this time. We should talk though, about going forward and how we want to approach continuing dev work on punchcard.

comments added to your review! thanks for that

scottnath commented 7 years ago

@Snugug can I get a merge please?