punesemu / puNES

Qt-based Nintendo Entertaiment System emulator and NSF/NSF2/NSFe Music Player (Linux, FreeBSD, OpenBSD and Windows)
GNU General Public License v2.0
624 stars 41 forks source link

Nes controller animated was missed since v0.96 I think #319

Open spotanjo3 opened 1 year ago

spotanjo3 commented 1 year ago

Whatever happened to NES Controller png like this:

https://emutopia.com/index.php?option=com_cobalt&task=files.show&id=12212&user_id=42&fldr=gallery19-417&file_key=c60e890146eb64224b8bcd6ddcebe5e8&tmpl=component

Can you bring it back ? I dont liked your input set up in blank without this cool NES controller animated input.

anewuser commented 1 year ago

There was no animation. That was just an illustration to remind people of what the controller looks like.

It was replaced years ago because of https://github.com/punesemu/puNES/issues/63, and then removed altogether last December (https://github.com/punesemu/puNES/commit/ad268a016db598059dfa5c8841c568988a973708).

The current configuration dialog has the shape of the controller and is fully functional, so there's no need to show an image anymore. You only have to look at it once.

spotanjo3 commented 1 year ago

Can you tell me the reason why ? I think this animation is awesome. Nice to click the input while looking at classic nes controller animation. Thats what I really like. ^_^

RokkumanX commented 6 months ago

Actually it wasn't a .png file but instead a .svg file and it was called Nes_controller.svg

And let me tell you that it was a pain in the azz to work with, I'm the very same RokkumanX that made the final result that you all saw for a while.

I wasn't 100% happy with what I made but I'm glad it got replaced with other approaches.

So, NO, don't bring that back please!

spotanjo3 commented 6 months ago

Ahh. I see. Thanks for the explanation. I like my old version so I think I will stick with old emulator. It worked fine with my favorite games anyway. A nes controller is more beautiful than a blank one.

RokkumanX commented 6 months ago

I'm not going to talk you out of using an old version as that would be sacrilegious, I'm guilty of doing the same thing especially with higan (Super Famicom Accuracy) for RetroArch.

If it ain't broke don't fix it.

However, you might want to try a new version out once in a while because you could potentially miss out on accuracy improvements and other improvements.

But I understand your way of thinking completely as I'm the same.

EDIT: I'm 99% sure the author (FHorse) won't bring back the old UI for the controller section so it's 99% sure to say it's safe to close this issue.

spotanjo3 commented 6 months ago

I understand. I dont blame the author but as you said if it ain't broke don't fix it. I dont care about the new feature and such as long as I have my favorit games flawless with my old verison and an awesome nes pad animation and I am keeping it. Thanks. ^_^

RokkumanX commented 6 months ago

And in the end it's all that matters!

ghost commented 6 months ago

@spotanjo3 There is a solution, thankfully Fabio made the emulator open source, you can download it and modify it as you want and there you will have the NES controller while benefiting from up to date changes.

spotanjo3 commented 6 months ago

Whats the difference between SDL, D3D9 and [Generic Binary] ?

ghost commented 6 months ago

@spotanjo3 SDL and D3D9 are graphics libraries, while generic binary is the format that can contain executable code for multiple CPU architectures.