search

punesemu / puNES

Qt-based Nintendo Entertaiment System emulator and NSF/NSF2/NSFe Music Player (Linux, FreeBSD, OpenBSD and Windows)
GNU General Public License v2.0
633 stars 42 forks source link

Mapper 561 typo in submapper 6/7 #375

Closed negativeExponent closed 7 months ago

negativeExponent commented 7 months ago

submapper 6 support is broken. PRG bank is suppose to be from the latch (m561.reg} instead of prg regs.

memmap_auto_wp_8k(0, MMCPU(0x8000), m561.reg & 0x0F, TRUE, wr);
memmap_auto_wp_8k(0, MMCPU(0xA000), m561.reg >> 4, TRUE, wr);

instead of

memmap_auto_wp_8k(0, MMCPU(0x8000), m561.prg[0], TRUE, wr);
memmap_auto_wp_8k(0, MMCPU(0xA000), m561.prg[1], TRUE, wr);

submapper 7 has the same issue, but i have no roms to test it on. this is probably a typo in nesdev's docs.

punesemu commented 7 months ago

Hi @negativeExponent, can you send me some roms that use submapper 6? I don't have any.

negativeExponent commented 7 months ago

heres all the mapper 561 i have. the ones starting with Nxx should be mostly submapper 6

mapper_561.zip

punesemu commented 7 months ago

Many thx.

ghost commented 7 months ago

Which rom there are many, tried a lot but hard to find submapper 6

punesemu commented 7 months ago

Thanks Chipsum, but thanks to those sent by negativeExponent I have already found the ones that interest me.

punesemu commented 7 months ago

Fixed, thx for the report.