punesemu / puNES

Qt-based Nintendo Entertaiment System emulator and NSF/NSF2/NSFe Music Player (Linux, FreeBSD, OpenBSD and Windows)
GNU General Public License v2.0
633 stars 42 forks source link

m176: submapper1 issue in new dumps #394

Closed negativeExponent closed 5 months ago

negativeExponent commented 6 months ago

submapper1 is incorrect in some newer dumps.

https://github.com/punesemu/puNES/blob/e1516fcefe3dcc9710ae85cce0f536fd2d9fdcd6/src/core/mappers/mapper_176.c#L216 this should be if ((mode == 0) && ext) {

ditto (but no ext check) https://github.com/punesemu/puNES/blob/e1516fcefe3dcc9710ae85cce0f536fd2d9fdcd6/src/core/mappers/mapper_176.c#L226

then 500xreg[0] is initialized to back to zero like it was before.

punesemu commented 5 months ago

Hi @negativeExponent, please can you send me some of these new dumps?

negativeExponent commented 5 months ago

here: m176_new.zip

it should be the games in the alternate menu

punesemu commented 5 months ago

As usual, thank you @negativeExponent.