punica-ai / punica

Serving multiple LoRA finetuned LLM as one
https://arxiv.org/abs/2310.18547
Apache License 2.0
883 stars 40 forks source link

[FIX] Benchmark build script #10

Closed jeromeku closed 7 months ago

jeromeku commented 7 months ago

The current CMakeLists.txt for nvbench has an incorrect include path: target_include_directories(${bench_name} PUBLIC ${PROJECT_SOURCE_DIR}/punica/ops/csrc), which needs to be changed to target_include_directories(${bench_name} PUBLIC ${PROJECT_SOURCE_DIR}/csrc) for the benchmark target to compile correctly.

abcdabcd987 commented 7 months ago

Awesome! Thanks!

I should setup CI to catch these bugs.