search

puniverse / comsat

Fibers and actors for web development
docs.paralleluniverse.co/comsat
Other
598 stars 103 forks source link

HttpChannel calls unsupported close() on 400-600 HTTP codes #49

Closed roded closed 8 years ago

roded commented 8 years ago

Hi, Seems like HttpChannel is calling its close() on HTTP errors (400-600) and redirects. This seems to make it impossible to return HTTP errors without an UnsupportedOperationException. Or is there something I missed?

circlespainter commented 8 years ago

Can you try with 0.6.0-SNAPSHOT?

roded commented 8 years ago

Same behaviour. Should I submit a PR which removes the close() calls?

circlespainter commented 8 years ago

I see it's still present in comsat-actors-servlet, is that the backend you're using?

It should be been fixed already in the Sonatype-published 0.6.0-SNAPSHOT artifacts for comsat-actors-undertow and comsat-actors-netty (which at present are from the webperf branch about performance improvements).

Thanks for proposing a PR but I'd rather do it myself as I'd like to refactor few more things according to the latest performance work done in the Netty and Undertow backends.

Also, if you're not forced to use servlets I suggest you to consider the Netty or Undertow ones as they're faster (because they integrate the backend's native API directly).

roded commented 8 years ago

Yeah, I've been using comsat-actors-servlet. I'll switch promptly.

Is there a release date for 0.6.0?

circlespainter commented 8 years ago

No but probably it won't be long.

circlespainter commented 8 years ago

A new 0.6.0-SNAPSHOT should be available on Sonatype with a fix.

circlespainter commented 8 years ago

0.6.0 released.