search

puniverse / comsat

Fibers and actors for web development
docs.paralleluniverse.co/comsat
Other
598 stars 103 forks source link

WebActorInitializer should not assert on the presence of websockets #74

Closed victornoel closed 7 years ago

victornoel commented 7 years ago

Hi,

For people using web actors without websockets, it is not needed to assert on the presence of websockets in a servlet container, actually, it is a problem if one does not want to enable them!

Maybe the check should be done only in case the @WebActor annotation has web socket url patterns?

pron commented 7 years ago

Sure, makes sense. Want to submit a PR?

victornoel commented 7 years ago

Oh, yeah, no problem, will do :)

victornoel commented 7 years ago

And here it is :)

By the way @pron, is there any ETA for the next release of comsat?

pron commented 7 years ago

Thanks. This usually depends on the number of features/bugs and accumulated and their utility/severity. I think we're up for a release very soon.