search

puniverse / comsat

Fibers and actors for web development
docs.paralleluniverse.co/comsat
Other
598 stars 103 forks source link

Any plans 0.7.1 with Redis support #83

Open sheinbergon opened 7 years ago

sheinbergon commented 7 years ago

Hi

I'm aware of https://github.com/puniverse/comsat/issues/7

However , I also found this

https://github.com/circlespainter/quasar-redis-example

@circlespainter / @pron amazing work.

What is the plan to merge the 'redis' branch to the master and release 'comsat-redis' as a stable feature ?

Can I help with something ?

sheinbergon commented 7 years ago

@pron any comment ?

circlespainter commented 7 years ago

comsat-redis implements Jedis only partially at this stage and, being a very young integration and notwithstanding the port of the test suite, there might well be serious bugs (e.g. performance or stability) when actually using it, so I'm not for releasing it immediately in an official stable.

It is also true that a wider user base would help with the sharp edges. @pron What do you think?

As for help sure, you could PR Jedis API coverage and more tests.

pron commented 7 years ago

Perhaps @sheinbergon can give it a try using the redis branch, and we'll decide based on his experience.

sheinbergon commented 7 years ago

Do you have any holes you'd like to cover in specific ? Concurrency tests ? I'm willing to help , just provide the what :-)

circlespainter commented 7 years ago

Here are a few ideas:

sheinbergon commented 7 years ago

@circlespainter @pron

OK . I'll run some manual tests for now the first chance I have and report back on the following subjects :