puniverse / comsat

Fibers and actors for web development
docs.paralleluniverse.co/comsat
Other
598 stars 103 forks source link

make .path() work for jaxrs fibers #9

Closed blekinge closed 10 years ago

blekinge commented 10 years ago

from FiberWebTarget.java

    @Override
    public WebTarget path(String path) {
        webTarget.path(path);
        return this;
    }

This should be

    @Override
    public WebTarget path(String path) {
        webTarget = webTarget.path(path);
        return this;
    }

as the path method in the JerseyWebTarget DOES NOT do inplace modification of the path

pron commented 10 years ago

Thank you. We'll fix that.

blekinge commented 10 years ago

I think you missed some other functions that should have been fixed at the same time. All the resolveTemplate* methods should be fixed the same way the queryParam and matrixParam methods should also be fixed.

pron commented 10 years ago

Right. Thanks again. I think we got it this time.